🤖 ci: add retry helper and throw on stream timeout #1099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammar-agent
changed the title
ammar-agent
force-pushed
the
ipc-testing-hwjw
branch
2 times, most recently
from
800a26b to
4b2a28c
Compare
- Add configureTestRetries helper to tests/ipc/helpers.ts that only enables retries in CI environment - Fix sendMessageAndWait to throw explicit error on timeout instead of silently returning incomplete events - Add retry to runtimeFileEditing.test.ts to handle transient API issues - DRY up 6 other test files to use the new helper Fixes flaky runtimeFileEditing test where stream-end wasn't found due to API latency/rate limiting causing 15s timeout. _Generated with mux_
ammar-agent
force-pushed
the
ipc-testing-hwjw
branch
from
4b2a28c to
d6e3b84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flaky
runtimeFileEditing.test.tswherestream-endwasn't found due to API latency/rate limiting causing 15s timeout.Changes
configureTestRetrieshelper totests/ipc/helpers.tsthat only enables retries in CI environmentsendMessageAndWaitto throw explicit error on timeout instead of silently returning incomplete eventsruntimeFileEditing.test.tsto handle transient API issuesGenerated with mux